Skip to content

Adds PreIncrement & PreDecrement opcodes; fixes comparison operators#2666

Open
ike709 wants to merge 5 commits into
OpenDreamProject:masterfrom
ike709:preop_time
Open

Adds PreIncrement & PreDecrement opcodes; fixes comparison operators#2666
ike709 wants to merge 5 commits into
OpenDreamProject:masterfrom
ike709:preop_time

Conversation

@ike709

@ike709 ike709 commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

The new unit tests passed in BYOND but not OpenDream.

This fixes ++/-- the parity issue by creating dedicated PreIncrement/PreDecrement opcodes with matching behavior. Deduplicated the opcode handlers with a shared helper method.

This also fixes the greater than / less than comparison operators (and the "or equals to" variants) with some types.

@ike709
ike709 requested a review from wixoaGit July 18, 2026 10:01
@boring-cyborg boring-cyborg Bot added Compiler Involves the OpenDream compiler Runtime Involves the OpenDream server/runtime labels Jul 18, 2026
@ike709 ike709 changed the title Adds PreIncrement & PreDecrement opcodes Adds PreIncrement & PreDecrement opcodes; fixes comparison operators Jul 18, 2026
@github-actions github-actions Bot added size/L and removed size/M labels Jul 18, 2026
Comment thread OpenDreamRuntime/Procs/DMOpcodeHandlers.cs Outdated
@ike709
ike709 requested a review from wixoaGit July 27, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compiler Involves the OpenDream compiler Runtime Involves the OpenDream server/runtime size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants